Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clparse (instead of heylogs) #10641

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Use clparse (instead of heylogs) #10641

merged 2 commits into from
Nov 15, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Nov 14, 2023

This implements NiclasvanEyk/keepac#20 (comment). Since marcaddeo/clparse#22 was solved, this should be possible.

Also updated heylogs to the latest release.

Follow-up to #10631.

Screenshot for failing check:

grafik

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

- Use clparse in tests.yml
- Use official release of heylogs
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 15, 2023
Copy link
Contributor

github-actions bot commented Nov 15, 2023

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit 14664c3 Nov 15, 2023
18 checks passed
@Siedlerchr Siedlerchr deleted the switch-to-clparse branch November 15, 2023 22:20
Siedlerchr added a commit to xuanan20020/jabref that referenced this pull request Nov 21, 2023
* upstream/main: (24 commits)
  Clean up test code (JabRef#10658)
  Bump org.openrewrite.rewrite from 6.4.0 to 6.5.4 (JabRef#10650)
  Bump com.puppycrawl.tools:checkstyle from 10.12.4 to 10.12.5 (JabRef#10654)
  Bump com.fasterxml.jackson.dataformat:jackson-dataformat-yaml (JabRef#10653)
  Bump com.github.Dansoftowner:jSystemThemeDetector from 3.6 to 3.8
  Remove comments - don't work on forks
  Update journal abbreviation lists (JabRef#10645)
  Use clparse (instead of heylogs) (JabRef#10641)
  Update CSL styles (JabRef#10642)
  Added parent field to Hayagriva YAML export (JabRef#10633)
  Bump org.fxmisc.richtext:richtextfx from 0.11.1 to 0.11.2 (JabRef#10637)
  Bump io.github.classgraph:classgraph from 4.8.163 to 4.8.164 (JabRef#10634)
  Bump org.junit.platform:junit-platform-launcher from 1.10.0 to 1.10.1 (JabRef#10635)
  Bump org.mockito:mockito-core from 5.6.0 to 5.7.0 (JabRef#10638)
  Bump com.tngtech.archunit:archunit-junit5-engine from 1.1.0 to 1.2.0 (JabRef#10636)
  add some more spaces
  Fix CHANGELOG.md
  Remove SearchListener
  Refactor method name to reflect usage
  Revert "Remove filtering on query in maintable"
  ...
Siedlerchr added a commit that referenced this pull request Nov 26, 2023
* upstream/main:
  Update journal abbreviation lists (#10645)
  Use clparse (instead of heylogs) (#10641)
  Update CSL styles (#10642)
  Added parent field to Hayagriva YAML export (#10633)
  Bump org.fxmisc.richtext:richtextfx from 0.11.1 to 0.11.2 (#10637)
  Bump io.github.classgraph:classgraph from 4.8.163 to 4.8.164 (#10634)
  Bump org.junit.platform:junit-platform-launcher from 1.10.0 to 1.10.1 (#10635)
  Bump org.mockito:mockito-core from 5.6.0 to 5.7.0 (#10638)
  Bump com.tngtech.archunit:archunit-junit5-engine from 1.1.0 to 1.2.0 (#10636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants